Unskip Blink UPF unittests
Unskips several Blink unexpected pass finder unittests that were skipped
due to the Catapult version of pyfakefs being used instead of the
vpython version. The vpython version seems to be used now, so these
tests pass when run under vpython3.
Bug: 1305104
Change-Id: Id32d4af6a7d9928ad3866c766e54ba3eab73dbab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4137084
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Auto-Submit: Brian Sheedy <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1089751}
diff --git a/BUILD.gn b/BUILD.gn
index 21450b75..545f306 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -1617,6 +1617,7 @@
"//third_party/blink/renderer/build/scripts/",
"//third_party/blink/tools/",
"//third_party/blink/web_tests/ASANExpectations",
+ "//third_party/blink/web_tests/FlagExpectations/",
"//third_party/blink/web_tests/LeakExpectations",
"//third_party/blink/web_tests/MSANExpectations",
"//third_party/blink/web_tests/NeverFixTests",
@@ -1624,6 +1625,7 @@
"//third_party/blink/web_tests/StaleTestExpectations",
"//third_party/blink/web_tests/TestExpectations",
"//third_party/blink/web_tests/VirtualTestSuites",
+ "//third_party/blink/web_tests/W3CImportExpectations",
"//third_party/catapult/common/py_utils/",
"//third_party/catapult/devil/",
"//third_party/catapult/dependency_manager/",
diff --git a/third_party/blink/tools/blinkpy/web_tests/stale_expectation_removal/expectations_unittest.py b/third_party/blink/tools/blinkpy/web_tests/stale_expectation_removal/expectations_unittest.py
index 8a9045f..566223dc 100755
--- a/third_party/blink/tools/blinkpy/web_tests/stale_expectation_removal/expectations_unittest.py
+++ b/third_party/blink/tools/blinkpy/web_tests/stale_expectation_removal/expectations_unittest.py
@@ -36,7 +36,6 @@
os.path.join(constants.WEB_TEST_ROOT_DIR, 'FlagExpectations',
'README.txt'))
- @unittest.skip('Skipped due to crbug/1305104')
def testRealFilesCanBeFound(self) -> None:
"""Tests that real files are returned."""
with fake_filesystem_unittest.Pause(self):
@@ -83,7 +82,6 @@
self.setUpPyfakefs()
self.instance = expectations.WebTestExpectations()
- @unittest.skip('Skipped due to crbug/1305104')
def testRealContentsCanBeLoaded(self) -> None:
"""Tests that some sort of valid content can be read from the file."""
with fake_filesystem_unittest.Pause(self):
