Finch trial for EV/Secure chip UI reduction
This adds a new Finch variation changing the EV/Secure chip UI
(downgrading EV to Secure, downgrading Secure to Lock only, or downgrading
both to Lock only). It changes LocationBarView and LocationBarViewMac to
directly use ToolbarModel::GetSecureVerboseText(), and adds logic for
handling the experimental cases. It also adds browsertests for testing the
security levels and indicator text for the different variations.
Bug: 803508
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I76014c18f0c2535766efd75d3eb2491cd7ab91c7
Reviewed-on: https://chromium-review.googlesource.com/877400
Commit-Queue: Christopher Thompson <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/master@{#533793}diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index f32e1dfa6..66e9c4db 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -83,6 +83,7 @@
#include "components/ssl_config/ssl_config_switches.h"
#include "components/suggestions/features.h"
#include "components/sync/driver/sync_driver_switches.h"
+#include "components/toolbar/toolbar_field_trial.h"
#include "components/tracing/common/tracing_switches.h"
#include "components/translate/core/browser/translate_prefs.h"
#include "components/translate/core/browser/translate_ranker_impl.h"
@@ -1174,6 +1175,25 @@
nullptr}};
#endif // defined(OS_ANDROID) && BUILDFLAG(ENABLE_VR)
+const FeatureEntry::FeatureParam kSimplifyHttpsIndicatorEvToSecure[] = {
+ {toolbar::features::kSimplifyHttpsIndicatorParameterName,
+ toolbar::features::kSimplifyHttpsIndicatorParameterEvToSecure}};
+const FeatureEntry::FeatureParam kSimplifyHttpsIndicatorSecureToLock[] = {
+ {toolbar::features::kSimplifyHttpsIndicatorParameterName,
+ toolbar::features::kSimplifyHttpsIndicatorParameterSecureToLock}};
+const FeatureEntry::FeatureParam kSimplifyHttpsIndicatorBothToLock[] = {
+ {toolbar::features::kSimplifyHttpsIndicatorParameterName,
+ toolbar::features::kSimplifyHttpsIndicatorParameterBothToLock}};
+
+const FeatureEntry::FeatureVariation kSimplifyHttpsIndicatorVariations[] = {
+ {"(show Secure chip for EV pages)", kSimplifyHttpsIndicatorEvToSecure,
+ arraysize(kSimplifyHttpsIndicatorEvToSecure), nullptr},
+ {"(show Lock icon for non-EV HTTPS pages)",
+ kSimplifyHttpsIndicatorSecureToLock,
+ arraysize(kSimplifyHttpsIndicatorSecureToLock), nullptr},
+ {"(show Lock icon for all HTTPS pages)", kSimplifyHttpsIndicatorBothToLock,
+ arraysize(kSimplifyHttpsIndicatorBothToLock), nullptr}};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the entry is the internal name.
@@ -3705,6 +3725,12 @@
flag_descriptions::kUnifiedConsentDescription, kOsAll,
FEATURE_VALUE_TYPE(features::kUnifiedConsent)},
+ {"simplify-https-indicator", flag_descriptions::kSimplifyHttpsIndicatorName,
+ flag_descriptions::kSimplifyHttpsIndicatorDescription, kOsDesktop,
+ FEATURE_WITH_PARAMS_VALUE_TYPE(toolbar::features::kSimplifyHttpsIndicator,
+ kSimplifyHttpsIndicatorVariations,
+ "SimplifyHttpsIndicator")},
+
// NOTE: Adding a new flag requires adding a corresponding entry to enum
// "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
// Histograms" in tools/metrics/histograms/README.md (run the
