Change never-visible terminology for RenderWidgets to never-composited.
The terminology was defined around never Showing a RenderWidget to the
user and thus not compositing it. However visibility is now split
between Widgets (show for compositing) and Views/Pages (show for blink
timers/js). And since we plumb this bit through RenderView creation and
store it there, it becomes ambiguous. This renames it throughout to be
more clear that it is about compositing (ie RenderWidgets) and not
about page visiblity.
[email protected], [email protected]
TBR=sky
Bug: 419087
Change-Id: Ic95d7c0eae473d5a1adfc369fd88272471f6fafb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992343
Commit-Queue: danakj <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#729855}
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 6578477..f68eb4b0 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1076,8 +1076,8 @@
return;
// Don't allow accessibility to be enabled for WebContents that are never
- // visible, like background pages.
- if (IsNeverVisible())
+ // user-visible, like background pages.
+ if (IsNeverComposited())
return;
accessibility_mode_ = mode;
@@ -5689,10 +5689,10 @@
frame->ClearFocusedElement();
}
-bool WebContentsImpl::IsNeverVisible() {
+bool WebContentsImpl::IsNeverComposited() {
if (!delegate_)
return false;
- return delegate_->IsNeverVisible(this);
+ return delegate_->IsNeverComposited(this);
}
RenderViewHostDelegateView* WebContentsImpl::GetDelegateView() {
