Stop disabling force_compositing_mode for background RenderViews.
When a RenderView's WebContents are a VIEW_TYPE_BACKGROUND_CONTENTS or
a VIEW_TYPE_EXTENSION_BACKGROUND_PAGE, the RenderView is in the
background and never visible.
Currently we disable force_compositing_mode to prevent allocating a
GPU context for the view. Since force_compositing_mode is the standard
and we are deleting other code paths, we should stop trying to disable
the setting.
Instead, add a new parameter to the ViewMsg_New IPC for |background|,
and for a RenderView that |is_background|, when the RenderWidget makes
an OutputSurface for the compositor, it creates a new NullOutputSurface
which declares itself as a delegated compositor without a GPU context.
This puts the compositor into a similar state to software compositing,
but since the renderer never presents frames, the OutputSurface
provides no way of getting frames to the browser process.
[email protected], [email protected]
BUG=362165
Review URL: https://codereview.chromium.org/233093006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264075 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index c547aad70..190320a 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -348,7 +348,8 @@
RenderWidget::RenderWidget(blink::WebPopupType popup_type,
const blink::WebScreenInfo& screen_info,
bool swapped_out,
- bool hidden)
+ bool hidden,
+ bool never_visible)
: routing_id_(MSG_ROUTING_NONE),
surface_id_(0),
webwidget_(NULL),
@@ -365,6 +366,7 @@
num_swapbuffers_complete_pending_(0),
did_show_(false),
is_hidden_(hidden),
+ never_visible_(never_visible),
is_fullscreen_(false),
needs_repainting_on_restore_(false),
has_focus_(false),
@@ -433,7 +435,7 @@
const blink::WebScreenInfo& screen_info) {
DCHECK(opener_id != MSG_ROUTING_NONE);
scoped_refptr<RenderWidget> widget(
- new RenderWidget(popup_type, screen_info, false, false));
+ new RenderWidget(popup_type, screen_info, false, false, false));
if (widget->Init(opener_id)) { // adds reference on success.
return widget.get();
}
@@ -500,9 +502,8 @@
if (webwidget_ && is_threaded_compositing_enabled_) {
webwidget_->enterForceCompositingMode(true);
}
- if (compositor_) {
- compositor_->setSurfaceReady();
- }
+ if (compositor_)
+ StartCompositor();
DoDeferredUpdate();
Send(new ViewHostMsg_RenderViewReady(routing_id_));
@@ -880,6 +881,9 @@
}
scoped_ptr<cc::OutputSurface> RenderWidget::CreateOutputSurface(bool fallback) {
+ // For widgets that are never visible, we don't start the compositor, so we
+ // never get a request for a cc::OutputSurface.
+ DCHECK(!never_visible_);
#if defined(OS_ANDROID)
if (SynchronousCompositorFactory* factory =
@@ -1865,7 +1869,7 @@
compositor_->setViewportSize(size_, physical_backing_size_);
if (init_complete_)
- compositor_->setSurfaceReady();
+ StartCompositor();
}
blink::WebLayerTreeView* RenderWidget::layerTreeView() {
@@ -2658,6 +2662,14 @@
#endif
}
+void RenderWidget::StartCompositor() {
+ // For widgets that are never visible, we don't need the compositor to run
+ // at all.
+ if (never_visible_)
+ return;
+ compositor_->setSurfaceReady();
+}
+
void RenderWidget::SchedulePluginMove(const WebPluginGeometry& move) {
size_t i = 0;
for (; i < plugin_window_moves_.size(); ++i) {
