Use ESLint to disallow __defineGetter__, __defineSetter__ and friends.
Previously these checks were customly implemented in PRESUBMIT.py
Bug: 720034,425829
Change-Id: I04a11f680ace0a6b7d250f4116562ce3710eb27a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670274
Auto-Submit: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Reviewed-by: Dan Beam <[email protected]>
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Cr-Commit-Position: refs/heads/master@{#671504}
diff --git a/.eslintrc.js b/.eslintrc.js
index f8d9de4..8bcbd17b0 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -28,6 +28,22 @@
'from chrome://resources/js/util.js instead of ' +
'document.getElementById(\'id\')',
},
+ {
+ 'property': '__lookupGetter__',
+ 'message': 'Use Object.getOwnPropertyDescriptor',
+ },
+ {
+ 'property': '__lookupSetter__',
+ 'message': 'Use Object.getOwnPropertyDescriptor',
+ },
+ {
+ 'property': '__defineGetter__',
+ 'message': 'Use Object.defineProperty',
+ },
+ {
+ 'property': '__defineSetter__',
+ 'message': 'Use Object.defineProperty',
+ },
],
'semi': ['error', 'always'],
