Google Git
Sign in
chromium / chromium / src.git / 7c29eff9686ae821b0a9c43980db75a83397c3aa
commit7c29eff9686ae821b0a9c43980db75a83397c3aa[log] [tgz]
authorMark Seaborn <[email protected]>Wed Mar 23 20:08:14 2022
committerChromium LUCI CQ <[email protected]>Wed Mar 23 20:08:14 2022
tree605e6c3bb791709c72817ff2b72b183d41ce29d4
parent368657f2d0407717cbc823d595f47ba04eb27231 [diff]
NaCl: Allow building Chromium for ARM64 with "enable_nacl = true"

This is an initial step to enable NaCl to work in ARM64 Chromium using
ARM32 NaCl.  This disables building the parts of NaCl that would need
to be built as ARM32 (including nacl_helper and various untrusted
nexes).  It enables building NaCl support into the ARM64 chrome
executable.

With this change, various NaCl tests pass when run on ARM64 Ubuntu
(20.04), including this test:

  xvfb-run -a ./out/default/browser_tests --gtest_filter=PPAPINaClNewlibTest.PostMessage

That requires that the following files are copied from an ARM32 build
of Chromium:

  nacl_helper
  nacl_helper_bootstrap
  nacl_irt_arm.nexe
  ppapi_nacl_tests_newlib.nmf
  ppapi_nacl_tests_newlib_arm.nexe

Two changes will be needed after this:

 * Building NaCl trusted code as ARM32 in an ARM64 build
 * Building NaCl untrusted code (nexes) as ARM32 in an ARM64 build

Landing this change first allows those to be more easily implemented
and tested in either order.

Bug: 1299021
Change-Id: Ib25ebbe56c91ed735beb87b0b3479b8b7621b389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3430407
Reviewed-by: Derek Schuff <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Devlin Cronin <[email protected]>
Reviewed-by: Thomas Anderson <[email protected]>
Commit-Queue: Mark Seaborn <[email protected]>
Cr-Commit-Position: refs/heads/main@{#984490}
10 files changed
tree: 605e6c3bb791709c72817ff2b72b183d41ce29d4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.