Google Git
Sign in
chromium / chromium / src.git / 7d032b378c2081291cda3af49153d6d5673b4c2e
commit7d032b378c2081291cda3af49153d6d5673b4c2e[log] [tgz]
authorJohn Abd-El-Malek <[email protected]>Tue May 07 18:01:31 2019
committerCommit Bot <[email protected]>Tue May 07 18:01:31 2019
tree7813d42dd03d4e8a95520e70e3d1485881702a7d
parent8a93767ecd2aa0eea3fb253a8d9db5efd36dc114 [diff]
Remove ResourceType parameter from NetworkServiceClient::OnAuthRequired.

The browser needed two things:
-if it was for the main frame's navigation request: it can deduce this already from the process/frame ID
-if it's a cross-origin image request which depending on policy can bring up a login dialog: plumbed the policy to the renderer in RendererPreferences and reused ResourceRequest::do_not_prompt_for_login for this use case

This is a step towards the TODO to remove this from network::ResourceRequest, since network service
shouldn't know about this enum.

Bug: 960143

Change-Id: I32b09fc11bd00a054f7069388af457fd5ffe1a39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595563
Commit-Queue: John Abd-El-Malek <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#657328}
20 files changed
tree: 7813d42dd03d4e8a95520e70e3d1485881702a7d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .