Google Git
Sign in
chromium / chromium / src.git / 7eb405edf8d82bb1b8c7fc8f71b937549443a169
commit7eb405edf8d82bb1b8c7fc8f71b937549443a169[log] [tgz]
authorMatt Menke <[email protected]>Thu Apr 25 20:48:21 2019
committerCommit Bot <[email protected]>Thu Apr 25 20:48:21 2019
tree9ca4f5b430158d3cb09a2797a37b2d4be8f228d5
parent4dd211ad37fc3b67b26150bca3fe700a6af318b5 [diff]
ClientSocketPool:  Add argument to CancelRequest to cancel ConnectJobs

When requests end up using H2 connection pooling (Or even just using
an H2 connection established for another request), any in-progress
ConnectJobs won't be needed, so we should be able to abort them.

The new argument won't help us do anything about backup ConnectJobs,
created if the original request was taking too long, or multiple
ConnectJobs created for other reasons (Start 2 requests to a server,
cancel 1 of them for other reasons, and the other establishes an
H2 connection, and the other ConnectJob may still complete
successfully, and just be left idle in the socket pool).

Bug: 912727
Change-Id: I0428534a542b863866639412f82a3023df3d7066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582324
Commit-Queue: Matt Menke <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#654186}
13 files changed
tree: 9ca4f5b430158d3cb09a2797a37b2d4be8f228d5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .