Google Git
Sign in
chromium / chromium / src.git / 7f8566bd6ec482ff5ff5703af99df1d10babddb3
commit7f8566bd6ec482ff5ff5703af99df1d10babddb3[log] [tgz]
authorBruce Dawson <[email protected]>Fri May 06 16:22:18 2022
committerChromium LUCI CQ <[email protected]>Fri May 06 16:22:18 2022
tree6ad6db549bc72b22c1c56306d5d067d3ee3bc3a6
parentb0a53ec39b2b2728765073c195f2a44b81010b09 [diff]
Fix three android .java style violations

CheckJavaStyle treats style violations as presubmit errors, so getting
"presubmit --all" error-free requires fixing these. Two of the fixes
were trivial following of the recommendation. The third was skipping a
generated file (IWebApkApi.java) from all checking. The errors (edited)
were:
  chrome/android/features/vr/java/src/org/chromium/chrome/browser/vr/VrDaydreamApi.java:71: Please name the StrictModeContext variable "ignored"
  chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/XrActivityRestriction.java:43:12: '@SupportedActivity' annotation modifier does not precede non-annotation modifiers.
  chrome/android/webapk/shell_apk/src/org/chromium/webapk/lib/runtime_library/IWebApkApi.java:12:15: "abstract" modifier out of order with the JLS suggestions.

Bug: 1309977
Change-Id: Ieba3c71ba164c035e5b7f5c2b53f7e2be062e05d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3631510
Commit-Queue: Bruce Dawson <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1000393}
3 files changed
tree: 6ad6db549bc72b22c1c56306d5d067d3ee3bc3a6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.