| commit | 7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426 | [log] [tgz] |
|---|---|---|
| author | Jinho Bang <[email protected]> | Mon Jan 15 18:04:12 2018 |
| committer | Commit Bot <[email protected]> | Mon Jan 15 18:04:12 2018 |
| tree | 25bd9bd2781685123943905ed2c2d0193c0e4873 | |
| parent | f3a04acf71e4d53036200acce97157861b9f107c [diff] [blame] |
android: Replace base::MakeUnique with std::make_unique
Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/android.
This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)
This change also adds `#include <memory>` header except the following
two cases:
- Not add the header if the file contains the <memory> header
- Not add the header if the related header contains <memory> header
(The style guide[2] says that foo.cc can rely on foo.h's includes)
Confirmed no additional lint errors(by `git cl lint`) after this change.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
Bug: 755727
Change-Id: I216f1a4180be7604d91132cedf48eb9c015074a7
Reviewed-on: https://chromium-review.googlesource.com/867172
Reviewed-by: Bernhard Bauer <[email protected]>
Commit-Queue: Jinho Bang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#529310}diff --git a/chrome/browser/android/devtools_manager_delegate_android.cc b/chrome/browser/android/devtools_manager_delegate_android.cc index 7ab36d0..6fe04d8 100644 --- a/chrome/browser/android/devtools_manager_delegate_android.cc +++ b/chrome/browser/android/devtools_manager_delegate_android.cc
@@ -7,7 +7,6 @@ #include <map> #include "base/bind.h" -#include "base/memory/ptr_util.h" #include "base/strings/string_number_conversions.h" #include "base/strings/utf_string_conversions.h" #include "build/build_config.h" @@ -183,7 +182,7 @@ return result; result = DevToolsAgentHost::Forward(base::IntToString(tab->GetAndroidId()), - base::MakeUnique<TabProxyDelegate>(tab)); + std::make_unique<TabProxyDelegate>(tab)); tab->SetDevToolsAgentHost(result); return result; }