Google Git
Sign in
chromium / chromium / src.git / 80fea269cc5d175e2be98460f76f2084b3ec5a0b
commit80fea269cc5d175e2be98460f76f2084b3ec5a0b[log] [tgz]
authorLukasz Anforowicz <[email protected]>Wed Aug 29 18:31:49 2018
committerCommit Bot <[email protected]>Wed Aug 29 18:31:49 2018
tree93b8500e0564852be9ee6792f878cd49918b521f
parent2d61ec8861ccb5e2045cd5755d98284ce5ababb8 [diff]
[refactoring] Extract WebLocalFrame::CommitDataNavigationWithRequest.

This CL extracts the second half of CommitDataNavigation method into a
new CommitDataNavigationWithRequest method.  The new method is called by
the old WebLocalFrameImpl::CommitDataNavigation method and by
RenderFrameImpl::LoadNavigationErrorPageInternal.

The CL also consolidates and deduplicates RenderFrameImpl code related
to committing of error pages:

  - It avoids duplication of the code that calculates
    blink::WebFrameLoadType and blink::WebHistoryItem based
    on content::HistoryEntry*

  - It removes the need to pass arguments that either 1) do not differ
    among callers or 2) can be deduced from other arguments.  For example:
    - GURL(kUnreachableWebDataURL)
    - is_client_redirect

This CL should be a pure refactoring, with no change in behavior.

Bug: 874544
Change-Id: I0088ad6367407ba70aa28c550ca46d7121dd78eb
Reviewed-on: https://chromium-review.googlesource.com/1176230
Commit-Queue: Łukasz Anforowicz <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#587208}
7 files changed
tree: 93b8500e0564852be9ee6792f878cd49918b521f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .