Google Git
Sign in
chromium / chromium / src.git / 832af13591619c0ccbe9ccffa6403eecd7b834da
commit832af13591619c0ccbe9ccffa6403eecd7b834da[log] [tgz]
authorJun Mukai <[email protected]>Fri Nov 30 05:43:44 2018
committerCommit Bot <[email protected]>Fri Nov 30 05:43:44 2018
treefbb1bd76840396732133d2439459b03df87adae4
parent09142d5973cdfa57808b20e4acbaf35e700582b2 [diff]
fix tab-dragging with touch on immersive-mode for Mash

Things are really complicated when a tab is about to be dragged
with touch events during immersive fullscreen mode in Mash. The
details are depicted as
https://docs.google.com/document/d/1fS6YlkYUCqPCHJpVvKEVbgVilkmnPGl5x2a2kZvW7z0/edit?usp=sharing.

This CL allows Ash to pick up the right target window by setting
the insets when the reveal status is changed.

The test also needs to be fixed because:
- without reveal lock, it can't say the tabstrip is really there
  (and the insets are properly set)
- QuitWhenNotDragging needs to be executed for touch events too,
  otherwise it doesn't wait for asynchronous touch events.

Bug: 901544
Test: see the filter. also manually checked the behavior
Change-Id: I9215fd0198f48a0ac641cd850ff290513e185775
Reviewed-on: https://chromium-review.googlesource.com/c/1336370
Commit-Queue: Jun Mukai <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#612576}
12 files changed
tree: fbb1bd76840396732133d2439459b03df87adae4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .