Remove kNavigationImmediateResponse flag
Currently, the NavigationImmediateResponse feature is enabled by
default through a flag kNavigationImmediateResponseBody.
As this feature has been landed for some time, this patch removes this
flag and the support for the old behavior.
Bug: 1017705
Change-Id: If02d58b28ccaadfa1ca94e080217321521a009fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911148
Commit-Queue: Minggang Wang <[email protected]>
Reviewed-by: Shakti Sahu <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Commit-Position: refs/heads/master@{#716024}
diff --git a/content/renderer/loader/navigation_body_loader_unittest.cc b/content/renderer/loader/navigation_body_loader_unittest.cc
index c2a05811..27b7573 100644
--- a/content/renderer/loader/navigation_body_loader_unittest.cc
+++ b/content/renderer/loader/navigation_body_loader_unittest.cc
@@ -50,8 +50,7 @@
NavigationBodyLoader::FillNavigationParamsResponseAndBodyLoader(
std::move(common_params), std::move(commit_params), 1 /* request_id */,
network::mojom::URLResponseHead::New(),
- mojo::ScopedDataPipeConsumerHandle() /* response_body */,
- std::move(endpoints),
+ std::move(data_pipe_->consumer_handle), std::move(endpoints),
blink::scheduler::GetSingleThreadTaskRunnerForTesting(),
2 /* render_frame_id */, true /* is_main_frame */, &navigation_params);
loader_ = std::move(navigation_params.body_loader);
@@ -59,8 +58,6 @@
void StartLoading() {
loader_->StartLoadingBody(this, false /* use_isolated_code_cache */);
- client_ptr_->OnStartLoadingResponseBody(
- std::move(data_pipe_->consumer_handle));
base::RunLoop().RunUntilIdle();
}
@@ -317,11 +314,14 @@
blink::WebNavigationParams navigation_params;
auto endpoints = network::mojom::URLLoaderClientEndpoints::New();
+ mojo::ScopedDataPipeProducerHandle producer_handle;
+ mojo::ScopedDataPipeConsumerHandle consumer_handle;
+ MojoResult rv =
+ mojo::CreateDataPipe(nullptr, &producer_handle, &consumer_handle);
+ ASSERT_EQ(MOJO_RESULT_OK, rv);
NavigationBodyLoader::FillNavigationParamsResponseAndBodyLoader(
std::move(common_params), std::move(commit_params), 1 /* request_id */,
- std::move(response),
- mojo::ScopedDataPipeConsumerHandle() /* response_body */,
- std::move(endpoints),
+ std::move(response), std::move(consumer_handle), std::move(endpoints),
blink::scheduler::GetSingleThreadTaskRunnerForTesting(),
2 /* render_frame_id */, true /* is_main_frame */, &navigation_params);
EXPECT_TRUE(
