Remove mapping from layer id to effect node.
Instead change remaining callsites to use effect_tree_index().
In all cases changed, the effect node "owned" by that layer is
guaranteed to exist.
Enumerated use cases:
1. Scrollbars. These always have effect nodes for opacity, which is
enforced by the scrollbar's layer's OpacityCanAnimateOnImplThread()
always returning true if it actually animates, which forces an
effect node in c::PropertyTreeBuilder.
2. Composited animations on the impl thread. Similary to #1,
HasPotentiallyRunningOpacityAnimation will be true for all such
cases where Opacity is actually mutated.
3. cc::Layer::SetOpacity (main-thread): the code
in Layer::SetOpacity already has logic to force a property tree
rebuild if necessary to allocate the effect node, and mutate
it if no rebuild is necessary.
Bug: 718564
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2519a18428d9274ca1345e540e496643a4faf601
Reviewed-on: https://chromium-review.googlesource.com/522930
Commit-Queue: Chris harrelson <[email protected]>
Reviewed-by: Walter Korman <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/master@{#477392}9 files changed
