commit 84a973cb55a94553076d0dd209641745aba2df7b
author groby <groby@chromium.org> Fri Aug 21 21:45:39 2015
committer Commit bot <commit-bot@chromium.org> Fri Aug 21 21:46:14 2015
tree c18e5f0bf3ad76448047d099a14f0399327a6b52
parent c51769c465523760fa84c13e94ebc6239c3e3428

[Translate] Add support for Field Trial for translate bubble.

Adds both field trial support and a flag so users can force-disable
participation in the field trial. Flags tag precedence over field
trial.

BUG=507442

TEST=Run Chromium with a fresh profile and the command line flags below.
     Each time, load page in a foreign language (not system language)

     <no flags>
         Chromium should display a translate infobar

     --force-fieldtrials=TranslateNewUX/Enabled
         Chromium should display a translate bubble.

     --force-fieldtrials=TranslateNewUX/Enabled --disable-translate-new-ux
         Chromium should display a translate Infobar

      --enable-translate-new-ux
         Chromium should display a translate bubble.

Review URL: https://codereview.chromium.org/1302833003

Cr-Commit-Position: refs/heads/master@{#344869}

chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 20fe4a7..ec24192b 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1512,7 +1512,8 @@
      IDS_FLAGS_ENABLE_TRANSLATE_NEW_UX_NAME,
      IDS_FLAGS_ENABLE_TRANSLATE_NEW_UX_DESCRIPTION,
      kOsMac,
-     SINGLE_VALUE_TYPE(switches::kEnableTranslateNewUX)},
+     ENABLE_DISABLE_VALUE_TYPE(switches::kEnableTranslateNewUX,
+                               switches::kDisableTranslateNewUX)},
 #endif
 #if defined(TOOLKIT_VIEWS)
     {"disable-views-rect-based-targeting",  // FLAGS:RECORD_UMA