| commit | 84b8e89635e6c134fc13c6dd05fba87fe4a37de0 | [log] [tgz] |
|---|---|---|
| author | [email protected] <[email protected]@0039d316-1c4b-4281-b951-d872f2087c98> | Wed Jun 12 22:24:06 2013 |
| committer | [email protected] <[email protected]@0039d316-1c4b-4281-b951-d872f2087c98> | Wed Jun 12 22:24:06 2013 |
| tree | c019c1cb6c7548b94471d9611eb30ba54f391d70 | |
| parent | 90310a82a607a5c3203d34a16db41e2dbe1cfe34 [diff] |
Revert 205914 "Disable untrusted exception handling for PNaCl"
It looks like NaClBrowserTestPnacl.PnaclExceptionHandlingDisabled is failing on all bots. Here's the failure log:
NaClBrowserTestPnacl.PnaclExceptionHandlingDisabled:
HTTP server started on 127.0.0.1:59586...
sending server_data: {"host": "127.0.0.1", "port": 59586} (36 bytes)
Xlib: extension "RANDR" missing on display ":9".
[12210:12210:0612/145646:2107321901:INFO:nacl_browsertest_util.cc(131)] |||| [STARTUP]
[12210:12210:0612/145646:2107342348:INFO:CONSOLE(0)] "NativeClient: NaCl module load failed: manifest: program property 'portable' does not have required key: 'url'.", source: http://127.0.0.1:59586/files/pnacl_exception_handling_disabled.html?pnacl=1 (0)
[12210:12210:0612/145646:2107350315:INFO:nacl_browsertest_util.cc(131)] ||||
[CLIENT_ERROR] nacl_module / test_nexe did not load. Status: DONE / 'NaCl module load failed: manifest: program property 'portable' does not have required key: 'url'.'
[12210:12210:0612/145646:2107350584:INFO:nacl_browsertest_util.cc(131)] ||||
[12210:12210:0612/145646:2107350767:INFO:nacl_browsertest_util.cc(131)] |||| A nexe load error occured, aborting testing.
[12210:12210:0612/145646:2107350837:INFO:nacl_browsertest_util.cc(131)] ||||
[12210:12210:0612/145646:2107351209:INFO:nacl_browsertest_util.cc(131)] |||| [SHUTDOWN] 0 passed, 0 failed, 1 errors
../../chrome/test/nacl/nacl_browsertest_util.cc:254: Failure
Value of: handler.test_passed()
Actual: false
Expected: true
Test failed.
> Disable untrusted exception handling for PNaCl
>
> BUG= https://code.google.com/p/nativeclient/issues/detail?id=3444
> [email protected], [email protected], [email protected], [email protected], [email protected]
>
> Review URL: https://codereview.chromium.org/15901015
[email protected]
Review URL: https://codereview.chromium.org/16844007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205951 0039d316-1c4b-4281-b951-d872f2087c98