Google Git
Sign in
chromium / chromium / src.git / 8af75fc76de5b034c2d04b7d88fb5bb0732fd92e
commit8af75fc76de5b034c2d04b7d88fb5bb0732fd92e[log] [tgz]
authordanakj <[email protected]>Tue Oct 01 19:59:02 2019
committerCommit Bot <[email protected]>Tue Oct 01 19:59:02 2019
treeb6efef544f4ee8c207139419a3e2c45eac9cf990
parent0e079b73b13654b6c4660a10a323693c0968c63a [diff]
Track the real and emulated screen rects in popups from the PageProperties

Currently popup widgets will snapshot the main frame's ViewRect and
the emulated ViewRect (aka WidgetRect). The popup itself lives with real
screen infos, passed to UpdateSurfaceAndScreenInfo(), and since it never
does SynchronizeVisualPropertiesFromRenderView() it keeps those values.

The RenderWidget converts WindowRects that the popup specifies of
queries in and out of emulated space as needed. After this change, the
conversions are done against the live real and emulated ViewRects
instead of snapshotting them at creation, avoiding the need for
tracking states on RenderWidget.

[email protected]

Bug: 1006052
Change-Id: I611287afcccdc8e8e739ef2c31e78d06191f688f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833782
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: danakj <[email protected]>
Cr-Commit-Position: refs/heads/master@{#701720}
5 files changed
tree: b6efef544f4ee8c207139419a3e2c45eac9cf990
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. .vpython3
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .