Don't show status bar updates from originating renderer when fullscreen
In fullscreen mode WebContents has two renderviews. One for the
fullscreen display, and one for the originating page. It's entirely
possible that the renderer from the originating page tries to update
the status bar url. This seems to mostly occur because we can delay mouse
events so that when transitioning to fullscreen we can end up sending
a mouse event to the originating renderer after we're fullscreen,
which can result in the originating page trying to update the target
url of the status bar.
When fullscreen we should only care about updates from the fullscreen
renderer.
[email protected]
BUG=380005
TEST=see bug
Review URL: https://codereview.chromium.org/811523005
Cr-Commit-Position: refs/heads/master@{#310915}
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 23890dc..71581078 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -412,7 +412,8 @@
void UpdateState(RenderViewHost* render_view_host,
int32 page_id,
const PageState& page_state) override;
- void UpdateTargetURL(const GURL& url) override;
+ void UpdateTargetURL(RenderViewHost* render_view_host,
+ const GURL& url) override;
void Close(RenderViewHost* render_view_host) override;
void RequestMove(const gfx::Rect& new_bounds) override;
void DidCancelLoading() override;
@@ -502,6 +503,7 @@
ui::PageTransition transition_type) override;
void DidNavigateMainFramePreCommit(bool navigation_is_within_page) override;
void DidNavigateMainFramePostCommit(
+ RenderFrameHostImpl* render_frame_host,
const LoadCommittedDetails& details,
const FrameHostMsg_DidCommitProvisionalLoad_Params& params) override;
void DidNavigateAnyFramePostCommit(
