Omnibox: Code health - Remove select_all parameter from FocusLocationBar
Currently there is a a select_all parameter that we plumb through all
layers of FocusLocationBar or its equivalent.
This CL removes that parameter, and assumes it's always true. In other
words, any time we focus the location bar, we also select-all.
This parameter is pretty much always set to true. The only place where
that parameter is set to false is from renderer-initiated focuses.
Renderer-initiated focuses are used these scenarios:
1. When the New Tab Page is loaded, in which case the omnibox is empty,
and selecting all does nothing.
2. For media OffscreenTab, there is no location bar, but the absent
location bar is "focused" to prevent the page content from getting
input focus. See OffscreenTab::ShouldFocusLocationBarByDefault.
3. For the PresentationReceiverWindowController, there is also no
location bar. It's also to prevent the page content from getting
focus. See PresentationReceiverWindowController::
ShouldFocusLocationBarByDefault.
4. When a new tab loads with about:blank, this will change the behavior
to automatically select-all the "about:blank" text when the
location bar is auto-focused. This is a desirable change.
In all these cases, setting select_all to true would have no negative
effect.
Bug: 921777, 912722
Change-Id: Idefb493b196f89e23928e925ec9fcf015cac02fa
Reviewed-on: https://chromium-review.googlesource.com/c/1418450
Commit-Queue: Tommy Li <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#624213}diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index a44b10e..9e41df6 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -4153,9 +4153,9 @@
return delegate_ && delegate_->ShouldFocusLocationBarByDefault(this);
}
-void WebContentsImpl::SetFocusToLocationBar(bool select_all) {
+void WebContentsImpl::SetFocusToLocationBar() {
if (delegate_)
- delegate_->SetFocusToLocationBar(select_all);
+ delegate_->SetFocusToLocationBar();
}
void WebContentsImpl::DidStartNavigation(NavigationHandle* navigation_handle) {
