commit | 8f8498b3987d2036fb8f7e578c1d24e4a046e163 | [log] [tgz] |
---|---|---|
author | Wez <[email protected]> | Fri Aug 18 04:26:34 2017 |
committer | Commit Bot <[email protected]> | Fri Aug 18 04:26:34 2017 |
tree | a28d715b1f00ba4166f6108dfb2ab76c827640fe | |
parent | b53744615a689fc82e76e1847011d1f34aaa83f6 [diff] |
Fix SysInfo::AmountOfVirtualMemory and PlatformSharedBuffer::Map(). The meaning of base::SysInfo::AmountOfVirtualMemory() isn't well- specified (e.g. under Windows it returns the calling process' maximum address-space size, while under POSIX it returns the maximum memory available via brk()-based malloc()). Under Fuchsia the Virtual Memory Address Range is practically unlimited, so rather than return the size of e.g. the root VMAR object of the calling process, we just return zero (meaning "unlimited"). PlatformSharedBuffer::Map() was previously DCHECK()ing that mapping the underlying SharedMemory object succeeded, and then always returning "success" to the caller. This is fixed so that callers, including the Mojo PlatformSharedBufferTest.TooBig test, can handle the Map() failure. The PlatformSharedBuffer.TooBig test is fixed to actually attempt to Create() a too-big shared buffer, rather than a zero-byte one, and the test is removed from the Fuchsia test filters. Bug: 740791, 706592 Change-Id: I76d3f1e4201c8cc6c143e469e5d1f081b359aa38 Reviewed-on: https://chromium-review.googlesource.com/620293 Commit-Queue: Wez <[email protected]> Reviewed-by: Ken Rockot <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/master@{#495459}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .