commit | 92b4e34f79921e758732366cda31dcdaf63e830c | [log] [tgz] |
---|---|---|
author | Sylvain Defresne <[email protected]> | Mon Feb 04 15:16:19 2019 |
committer | Commit Bot <[email protected]> | Mon Feb 04 15:16:19 2019 |
tree | f933b369142ac1f8aab5ee448366934b95cb9682 | |
parent | 4e520adff497701395d7556331e754f7450f6220 [diff] |
Remove uses of deprecated override of PrefValueMap::SetValue Convert client of the deprecated of PrefValueMap::SetValue taking a std::unique_ptr<base::Value> to the recommended override taking a base::Value directly. The conversion is done using the following rules: - If the value is built inline using std::make_unique<base::Value> then change to just construct a base::Value directly, - If the value is built use base::Value::CreateDeepCopy(), then change to use base::Clone() which returns a base::Value instead of a std::unique_ptr<base::Value>, - If the std::unique_ptr<base::Value> is just forwarded by the caller, dcheck it is not null (the check was present in the old method implementation) and use base::Value::FromUniquePtrValue to convert the std::unique_ptr<base::Value> to a base::Value. This CL fixes uses in src/components/prefs. This CL was uploaded by git cl split. Bug: 646113 Change-Id: Ic727fe7912689d8bc81d151f1fbe306e19b8702a Reviewed-on: https://chromium-review.googlesource.com/c/1446223 Commit-Queue: Sylvain Defresne <[email protected]> Reviewed-by: Dominic Battré <[email protected]> Cr-Commit-Position: refs/heads/master@{#628743}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .