| commit | 938fda43077d4622c5b88984608d6becd5ebbb82 | [log] [tgz] |
|---|---|---|
| author | Khushal <[email protected]> | Thu Mar 12 17:20:11 2020 |
| committer | Commit Bot <[email protected]> | Thu Mar 12 17:20:11 2020 |
| tree | 79e28f4e4e9417365f436cc673b155c2180610f2 | |
| parent | 3559b9a9ab4a57ee167a389dbea43427a955ca64 [diff] |
cc/ui: Ensure UI resource bitmaps are correctly aligned for uploads. The GPU service code assumes that all textures uploads made directly to shared image interface are 4 byte aligned. While this is true for RGBA resources, which have 4 bytes per pixel, its not the case for ALPHA_8 resources. A mismatch in the expected size causes the upload to fail and the service side tears down the GL context. This change fixes the above by ensuring that UI resource creation code allocates and initializes the SkBitmaps with a 4 byte alignment. Bug:1013992 [email protected],[email protected] Change-Id: I2bd8e4ce7764573f2cc7b78ac8582346cf9baf7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093272 Reviewed-by: David Trainor <[email protected]> Reviewed-by: Kenneth Russell <[email protected]> Reviewed-by: Sami Kyöstilä <[email protected]> Commit-Queue: Khushal <[email protected]> Auto-Submit: Khushal <[email protected]> Cr-Commit-Position: refs/heads/master@{#749737}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.