Prepare browser tests for NoRendererCrashesAssertion.
This CL adds ScopedAllowRendererCrashes to browser tests that
(expectedly or unexpectedly) might trigger a renderer crash.
Right now a browser test might pass, even if a renderer process crashed
during the test execution. After https://crrev.com/c/1650463 a renderer
crash will trigger an explicit test failure, but before this enforcement
can start, existing tests that experience renderer crashes (expectedly
or unexpectedly) need to declare this via ScopedAllowRendererCrashes.
This CL was uploaded by git cl split.
[email protected]
Bug: 972220
Change-Id: Ibdc12339f569f79db7b59bd1caca00726743ea81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653421
Commit-Queue: Karan Bhatia <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Auto-Submit: Łukasz Anforowicz <[email protected]>
Cr-Commit-Position: refs/heads/master@{#669300}
diff --git a/chrome/browser/extensions/navigation_observer_browsertest.cc b/chrome/browser/extensions/navigation_observer_browsertest.cc
index 39aafe2..290bbff 100644
--- a/chrome/browser/extensions/navigation_observer_browsertest.cc
+++ b/chrome/browser/extensions/navigation_observer_browsertest.cc
@@ -10,6 +10,7 @@
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/navigation_observer.h"
#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/test/no_renderer_crashes_assertion.h"
#include "extensions/browser/extension_dialog_auto_confirm.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
@@ -21,6 +22,11 @@
// re-enable it.
IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest,
PromptToReEnableExtensionsOnNavigation) {
+ // TODO(lukasza): https://crbug.com/970917: We should not terminate a renderer
+ // that hosts a disabled extension. Once that is fixed, we should remove
+ // ScopedAllowRendererCrashes below.
+ content::ScopedAllowRendererCrashes scoped_allow_renderer_crashes;
+
NavigationObserver::SetAllowedRepeatedPromptingForTesting(true);
base::ScopedClosureRunner reset_repeated_prompting(base::BindOnce([]() {
NavigationObserver::SetAllowedRepeatedPromptingForTesting(false);
