Use correct IntToString variants in //chrome
Using IntToString() with a type larger than an int can lead to
unexpected truncation. Similarly, using it with an unsigned value can
lead to undesirable results.
Use the appropriate IntToString() variant for the type of the integer
being converted.
BUG=505479
TEST=compiled
Review URL: https://codereview.chromium.org/1358513003
Cr-Commit-Position: refs/heads/master@{#349846}
diff --git a/chrome/browser/internal_auth.cc b/chrome/browser/internal_auth.cc
index ef6c826..84d543c2 100644
--- a/chrome/browser/internal_auth.cc
+++ b/chrome/browser/internal_auth.cc
@@ -157,7 +157,7 @@
blob = domain + kItemSeparator;
std::string tmp;
ConvertVarValueMapToBlob(map, &tmp);
- blob += tmp + kItemSeparator + base::Uint64ToString(tick);
+ blob += tmp + kItemSeparator + base::Int64ToString(tick);
std::string hmac;
unsigned char* hmac_data = reinterpret_cast<unsigned char*>(
@@ -175,7 +175,7 @@
DCHECK(hmac_base64.size() < result.size());
std::copy(hmac_base64.begin(), hmac_base64.end(), result.begin());
- std::string tick_decimal = base::Uint64ToString(tick);
+ std::string tick_decimal = base::Int64ToString(tick);
DCHECK(tick_decimal.size() <= kTickStringLength);
std::copy(
tick_decimal.begin(),
