Remove separate fields for CT compliance details available
SSLInfo and CTVerifyResult both have a boolean field indicating whether the
compliance status field has been populated. It's easy for consumers to forget to
check the boolean, so this CL gets rid of it and folds it into the compliance
status field by introducing a new enum value to indicate that we don't know
anything about CT compliance.
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4ff270ebc6dba38b89cf2d1f078f9ef9cebc8422
Reviewed-on: https://chromium-review.googlesource.com/788175
Commit-Queue: Emily Stark <[email protected]>
Reviewed-by: Ryan Sleevi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#520041}diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index bc7273d8..1b1afc07 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -100,8 +100,10 @@
// Records per-request histograms relating to Certificate Transparency
// compliance.
void RecordCTHistograms(const net::SSLInfo& ssl_info) {
- if (!ssl_info.ct_compliance_details_available)
+ if (ssl_info.ct_policy_compliance ==
+ net::ct::CTPolicyCompliance::CT_POLICY_COMPLIANCE_DETAILS_NOT_AVAILABLE) {
return;
+ }
if (!ssl_info.is_issued_by_known_root)
return;
