| commit | 9689c569d59efae61ea29501b89b1ce801eaa505 | [log] [tgz] |
|---|---|---|
| author | Olivier Robin <[email protected]> | Fri Apr 17 14:03:57 2020 |
| committer | Commit Bot <[email protected]> | Fri Apr 17 14:03:57 2020 |
| tree | bc92d3f618b4fe0127c15db32b19ac5052391fd7 | |
| parent | 504e01c2dc701ac372c7323d8407947dacae60ae [diff] [blame] |
Add PRODUCT_BUNDLE_IDENTIFIER in xcode attributes Attribute is needed for some debug functions in Xcode (e.g. simulated MetricKit payload). Change-Id: I6ee8456a7dd4bc1ecc9e3ebc4e31526b2c5ad506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144039 Reviewed-by: Sylvain Defresne <[email protected]> Reviewed-by: John Chen <[email protected]> Reviewed-by: Olivier Robin <[email protected]> Commit-Queue: Olivier Robin <[email protected]> Cr-Commit-Position: refs/heads/master@{#760051}
diff --git a/testing/test.gni b/testing/test.gni index d2b54c2..bd2dd7c 100644 --- a/testing/test.gni +++ b/testing/test.gni
@@ -298,12 +298,14 @@ info_plist = "//testing/gtest_ios/unittest-Info.plist" } - _bundle_id_suffix = "${target_name}" + _gtest_bundle_id_suffix = "${target_name}" + xcode_product_bundle_id = "gtest.$_gtest_bundle_id_suffix" if (!defined(extra_substitutions)) { extra_substitutions = [] } - extra_substitutions += [ "GTEST_BUNDLE_ID_SUFFIX=$_bundle_id_suffix" ] + extra_substitutions += + [ "GTEST_BUNDLE_ID_SUFFIX=$_gtest_bundle_id_suffix" ] if (!defined(bundle_deps)) { bundle_deps = []