Google Git
Sign in
chromium / chromium / src.git / 989dbd8fc3af087ef525b437d498ee7941cbc6a3
commit989dbd8fc3af087ef525b437d498ee7941cbc6a3[log] [tgz]
authorLeonard Grey <[email protected]>Wed Mar 07 18:10:24 2018
committerCommit Bot <[email protected]>Wed Mar 07 18:10:24 2018
treeed28b82af824ff9c1b0f66e377ea8ee88fb8fc02
parent8e49dd7b1153274611c5c72f9e6de5895f1d5e08 [diff]
MacViews: reland 'Shim |ShowModalDialog| for Polychrome'

This was originally https://chromium-review.googlesource.com/c/chromium/src/+/929942
but was reverted because of the hacky way it implemented a components/ function
in Chrome.

It's now rebased on https://chromium-review.googlesource.com/c/chromium/src/+/949362
which made that behavior unnecessary.

Background:
Polychrome is an intermediate step to shipping MacViews browser.
Currently, switching between Cocoa browser and MacViews browser requires
a buildflag. Polychrome builds both Cocoa and MacViews into the same
binary and allows switching between them based on a feature flag.
More details at crbug.com/802257

As Cocoa and (much of) Views were not typically built together,
some symbols were reused. With Polychrome, these are duplicate symbols.
This CL resolves the issue by renaming the Cocoa symbols, and then
shimming them for the (regular, not Polychrome) Cocoa build.

Bug: 808017
Change-Id: Ia42c202e474614c97759aab28c88f580bc0ffabd
Reviewed-on: https://chromium-review.googlesource.com/950063
Reviewed-by: Mike Wittman <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Leonard Grey <[email protected]>
Cr-Commit-Position: refs/heads/master@{#541500}
4 files changed
tree: ed28b82af824ff9c1b0f66e377ea8ee88fb8fc02
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_cleaner/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. notification_helper/
  38. pdf/
  39. ppapi/
  40. printing/
  41. remoting/
  42. rlz/
  43. sandbox/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .