Fix some "gn check" issues for chrome/browser/extensions
Separate out a separate target for command_ids.h. Currently this was just being added to random targets. This removes it from the gypi files since this causes it to be confusigly added to a bunch of gn targets. The only use of this is for GYP analyze when this one header changes, which shouldn't be necessary any more.
There are a few minor fixes to //chrome/browser, but most of the fixes are to //chrome/browser/extensions. This change fixes about half of the errors in that target.
Review-Url: https://codereview.chromium.org/2170193002
Cr-Commit-Position: refs/heads/master@{#407932}
diff --git a/chrome/browser/extensions/BUILD.gn b/chrome/browser/extensions/BUILD.gn
index a38c519..15579231 100644
--- a/chrome/browser/extensions/BUILD.gn
+++ b/chrome/browser/extensions/BUILD.gn
@@ -39,6 +39,7 @@
"//chrome:extra_resources",
"//chrome:resources",
"//chrome:strings",
+ "//chrome/app:command_ids",
"//chrome/app/resources:platform_locale_settings",
"//chrome/app/theme:theme_resources",
"//chrome/browser/devtools",
@@ -47,15 +48,32 @@
"//chrome/common/extensions/api:extensions_features",
"//chrome/common/safe_browsing:proto",
"//chrome/installer/util:with_no_strings",
+ "//components/autofill/content/browser",
+ "//components/browser_sync/browser",
+ "//components/bubble",
+ "//components/content_settings/core/browser",
+ "//components/crx_file",
"//components/data_reduction_proxy/proto:data_reduction_proxy_proto",
"//components/dom_distiller/core",
+ "//components/favicon/content",
+ "//components/gcm_driver",
+ "//components/infobars/core",
+ "//components/keyed_service/content",
"//components/onc",
"//components/policy",
+ "//components/pref_registry",
"//components/proximity_auth",
+ "//components/proxy_config",
"//components/resources",
+ "//components/safe_json",
+ "//components/search_engines",
+ "//components/sessions",
+ "//components/signin/core/browser",
"//components/strings",
+ "//components/syncable_prefs",
"//components/update_client",
"//components/url_matcher",
+ "//components/web_modal",
"//content/app/resources",
"//content/public/common",
"//crypto",
@@ -84,6 +102,7 @@
"//ui/base/ime",
"//ui/gfx",
"//ui/gfx/geometry",
+ "//ui/native_theme",
"//ui/resources",
"//ui/strings",
"//url",
@@ -133,6 +152,7 @@
"api/tabs/ash_panel_contents.cc",
"api/tabs/ash_panel_contents.h",
]
+ deps += [ "//ash" ]
}
if (use_aura) {
