Enabling crc32 ARM instruction in zlib for ChromeOS.
Using the ARM crc32 instruction can boost the speed of gzip content
decompression, which can improve performances in cases where lots of
webpages are served using 'content-encoding: gzip'.
Expected to have ~50% decompression speed improvement on elm.
Bug: 848897, 810125
Change-Id: I9f090950209e6a68271c6926700b7335e14c7cbf
Reviewed-on: https://chromium-review.googlesource.com/c/1372548
Commit-Queue: Adenilson Cavalcanti <[email protected]>
Reviewed-by: Adenilson Cavalcanti <[email protected]>
Cr-Commit-Position: refs/heads/master@{#616210}diff --git a/third_party/zlib/BUILD.gn b/third_party/zlib/BUILD.gn
index 4764ec1c..51d477a 100644
--- a/third_party/zlib/BUILD.gn
+++ b/third_party/zlib/BUILD.gn
@@ -65,10 +65,9 @@
# - Disabled for iPhones, as described in DDI0487C_a_armv8_arm:
# "All implementations of the ARMv8.1 architecture are required to
# implement the CRC32* instructions. These are optional in ARMv8.0."
- # - ChromeOS has wrapper scripts that are borking the compiler flags.
# - Fuchsia just added a syscall for feature detection.
# TODO(cavalcantii): crbug.com/810125.
- if (!is_ios && !is_chromeos && !is_fuchsia) {
+ if (!is_ios && !is_fuchsia) {
defines = [ "CRC32_ARMV8_CRC32" ]
if (is_android) {
defines += [ "ARMV8_OS_ANDROID" ]
@@ -81,7 +80,7 @@
source_set("zlib_arm_crc32") {
visibility = [ ":*" ]
- if (is_clang && (!is_ios && !is_chromeos && !is_fuchsia)) {
+ if (is_clang && (!is_ios && !is_fuchsia)) {
include_dirs = [ "." ]
if (is_android) {
