Reland "[Fuchsia] Make hardware boot image downloading opt-in by .gclient."
This is a reland of d4f8b3f66bc6c661dba36ce611e1545de3118e13
All Fuchsia bots are now configured to download boot images, which should
address the previous breakage.
Original change's description:
> [Fuchsia] Make hardware boot image downloading opt-in by .gclient.
>
> Only download SDK system images for target CPU architectures which are
> explicitly configured in .gclient. Attempting to boot the SDK
> system image on a target CPU that was not configured will cause an
> explanatory message to be printed.
>
> If the .gclient variable is not set, then only QEMU images are
> downloaded for x64 and ARM64. This typically reduces the SDK download
> time by 30s, and data transfer/storage footprint by ~2.4GB versus
> the previous defaults, which downloaded boot images for all
> platform types and archs.
>
> This is useful for Chromium developers (e.g. sheriffs) who need to
> be able to build and run tests on Fuchsia, but don't want or need
> physical devices. It also speeds up the "gclient runhooks" step on
> Fuchsia buildbots.
>
> Bug: 990513
> Change-Id: I55a310830c050f247e37dae8289c472c16ff5dca
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732805
> Reviewed-by: Wez <[email protected]>
> Reviewed-by: Dirk Pranke <[email protected]>
> Reviewed-by: Nico Weber <[email protected]>
> Commit-Queue: Kevin Marshall <[email protected]>
> Auto-Submit: Kevin Marshall <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#685798}
Change-Id: I05df027d4830ecc7bb0510642436af2b36117d98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761058
Reviewed-by: Wez <[email protected]>
Commit-Queue: Kevin Marshall <[email protected]>
Cr-Commit-Position: refs/heads/master@{#690015}
diff --git a/DEPS b/DEPS
index 9742500..7878b61 100644
--- a/DEPS
+++ b/DEPS
@@ -104,6 +104,21 @@
# e.g. with custom_vars.
'checkout_ios_webkit': False,
+ # Fetches only the SDK boot images which match at least one of the whitelist
+ # entries in a comma-separated list.
+ #
+ # Only the X64 and ARM64 QEMU images are downloaded by default. Developers
+ # that need to boot on other target architectures or devices can opt to
+ # download more boot images. Example of images include:
+ #
+ # Emulation:
+ # qemu.x64, qemu.arm64
+ # Hardware:
+ # generic.x64, generic.arm64
+ #
+ # Wildcards are supported (e.g. "qemu.*").
+ 'checkout_fuchsia_boot_images': "qemu.x64,qemu.arm64",
+
# Default to the empty board. Desktop Chrome OS builds don't need cros SDK
# dependencies. Other Chrome OS builds should always define this explicitly.
'cros_board': '',
@@ -3159,6 +3174,7 @@
'action': [
'python',
'src/build/fuchsia/update_sdk.py',
+ '--boot-images={checkout_fuchsia_boot_images}',
],
},
