| commit | a1d07b92c3115ea494a0c50084a73776e3bc0e47 | [log] [tgz] |
|---|---|---|
| author | Charlie Hu <[email protected]> | Tue Nov 02 16:55:13 2021 |
| committer | Chromium LUCI CQ <[email protected]> | Tue Nov 02 16:55:13 2021 |
| tree | 70f12e6370c7593711944970018389fff7e91576 | |
| parent | c7397e0aef81776c2b994b39c5c2e8a5a6be8cd3 [diff] [blame] |
[Unwinder] Rename enum names in `UnwindResult` Enum names should use kMixedCase style. https://google.github.io/styleguide/cppguide.html#Enumerator_Names Change-Id: I5b8c5ef1e51fc37289fa8c36ffd56547484ab094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252933 Reviewed-by: Mike Wittman <[email protected]> Reviewed-by: Sami Kyöstilä <[email protected]> Commit-Queue: Charlie Hu <[email protected]> Cr-Commit-Position: refs/heads/main@{#937405}
diff --git a/base/profiler/chrome_unwinder_android_v2.cc b/base/profiler/chrome_unwinder_android_v2.cc index 015653d..5eb7bf8 100644 --- a/base/profiler/chrome_unwinder_android_v2.cc +++ b/base/profiler/chrome_unwinder_android_v2.cc
@@ -98,7 +98,7 @@ instruction_byte_offset_from_text_section_start); if (!function_offset_table_index) { - return UnwindResult::ABORTED; + return UnwindResult::kAborted; } const uint32_t current_unwind_instruction_index = @@ -120,13 +120,13 @@ instruction_result = ExecuteUnwindInstruction( current_unwind_instruction, pc_was_updated, thread_context); if (RegisterContextStackPointer(thread_context) >= stack_top) { - return UnwindResult::ABORTED; + return UnwindResult::kAborted; } } while (instruction_result == UnwindInstructionResult::kInstructionPending); if (instruction_result == UnwindInstructionResult::kAborted) { - return UnwindResult::ABORTED; + return UnwindResult::kAborted; } DCHECK_EQ(instruction_result, UnwindInstructionResult::kCompleted); @@ -134,7 +134,7 @@ module_cache()->GetModuleForAddress( RegisterContextInstructionPointer(thread_context))); } while (CanUnwindFrom(stack->back())); - return UnwindResult::UNRECOGNIZED_FRAME; + return UnwindResult::kUnrecognizedFrame; } UnwindInstructionResult ExecuteUnwindInstruction(