Google Git
Sign in
chromium / chromium / src.git / a1e27a49d4b9be4c99da5f2accaf40e6d7693a6c
commita1e27a49d4b9be4c99da5f2accaf40e6d7693a6c[log] [tgz]
authorCollin <[email protected]>Wed Jan 26 20:12:03 2022
committerChromium LUCI CQ <[email protected]>Wed Jan 26 20:12:03 2022
treec1a1a179c66a1ec1d2bc150155afce1061f7be04
parenta8195c3d677feac8f1f996f0b365c4ee418b1527 [diff]
Adapt, build, and test old Rust Mojo bindings

Continues work started in
https://chromium-review.googlesource.com/c/chromium/src/+/3233000 to
revive Rust mojo bindings used in previous standalone Mojo SDK.

These bindings are outdated. They referred to several Mojo core API
functions that no longer exist (e.g. wait sets), several other
functions now have different signatures, and the mojom encoding and
decoding does not match current Mojo among other things. Further,
these bindings have their own run loop implementation (based on
outdated wait sets). Integrating with current Mojo will require
significant changes:
* Updating the system bindings to closely match the C API
* Adding code gen support for mojom bindings
* Integrating mojom bindings with Chrome's run loop

As a proof-of-concept this CL adds the bindings and tests to the
build. Many of the tests succeed demonstrating the viability of
reviving these Rust bindings. The ones that fail are due to changes in
the API. The following changes were necessary to build and test
successfully:
* Fixed various 2018 edition build issues
* Added replacements for missing Mojo C API functions
* Updated several function signatures

Bug: 1274864
Change-Id: Ie3101e31d28a75f23cafd3a66e7fdf09b6ca2809
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3282310
Reviewed-by: Nico Weber <[email protected]>
Auto-Submit: Collin Baker <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Robert Sesek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#963667}
34 files changed
tree: c1a1a179c66a1ec1d2bc150155afce1061f7be04
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.