Google Git
Sign in
chromium / chromium / src.git / a21b3e4f064b3a6f39f153508b1a7041b4176c9e
commita21b3e4f064b3a6f39f153508b1a7041b4176c9e[log] [tgz]
authordpapad <[email protected]>Mon Mar 18 23:51:34 2024
committerChromium LUCI CQ <[email protected]>Mon Mar 18 23:51:34 2024
treef02dbe4d1c97a27e79fbbb9ba5c734e2aa89bc22
parentd9e30b3ab84420f836d41f75ed3e77f85e2fdc2e [diff]
WebUI: Disallow extension-less JS imports via ESLint, part 2 (last).

In this part adding a new no-restricted-syntax ESLint check that
catches such violations.

Per the JS styleguide at [1] all JS import statements should explitcly
specify the file extension. The TS styleguide does not seem to have
that requirement and shows examples where the extension is omitted [2].

Given the prevalence of non-extensionless imports in Chromium's
codebase it seems better to follow the JS styleguide for both JS and
TS to be consistent with the vast majority of existing code.

[1] https://google.github.io/styleguide/jsguide.html#es-module-imports
[2] https://google.github.io/styleguide/tsguide.html#imports

Bug: 40519637
Change-Id: Ic941f5b4b648d8a8f1780fdeef3e348b6e44fedf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5375665
Commit-Queue: Demetrios Papadopoulos <[email protected]>
Reviewed-by: Rebekah Potter <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1274565}
1 file changed
tree: f02dbe4d1c97a27e79fbbb9ba5c734e2aa89bc22
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.