| commit | a43d5b4e2a84f49d1c25029ddeeaa33484b11ebb | [log] [tgz] |
|---|---|---|
| author | Roman Karasev <[email protected]> | Thu Dec 21 03:06:02 2017 |
| committer | Commit Bot <[email protected]> | Thu Dec 21 18:55:12 2017 |
| tree | 7c6e4fd6d63f3c06c74772e8d364195ddaedc54b | |
| parent | 2540c9393da72a68402841bb9c6aafa175da7d6d [diff] [blame] |
ACCESS_VIOLATION exception When IPC::Message is constructed from empty data, it has invalid state. Attempt to access its header (e.g. calling type() method) leads to ACCESS_VIOLATION exception because header_ is nullptr at this time. Change-Id: Id58df83d49d4de5f3d459c600abdecc76da36ecc Bug: 793749 Change-Id: Id58df83d49d4de5f3d459c600abdecc76da36ecc Reviewed-on: https://chromium-review.googlesource.com/800076 Commit-Queue: danakj <[email protected]> Reviewed-by: John Abd-El-Malek <[email protected]> Reviewed-by: danakj <[email protected]> Reviewed-by: Ken Rockot <[email protected]> Reviewed-by: Tom Sepez <[email protected]> Cr-Commit-Position: refs/heads/master@{#525754}
diff --git a/ipc/ipc_channel_mojo.h b/ipc/ipc_channel_mojo.h index 340d80c..aa6ba435 100644 --- a/ipc/ipc_channel_mojo.h +++ b/ipc/ipc_channel_mojo.h
@@ -89,6 +89,7 @@ // MessagePipeReader::Delegate void OnPeerPidReceived(int32_t peer_pid) override; void OnMessageReceived(const Message& message) override; + void OnBrokenDataReceived() override; void OnPipeError() override; void OnAssociatedInterfaceRequest( const std::string& name,