| commit | a4bce7ad0bdf13e8fe4f9824f65148fff0d7d972 | [log] [tgz] |
|---|---|---|
| author | Eric Karl <[email protected]> | Sat Jan 12 00:10:54 2019 |
| committer | Commit Bot <[email protected]> | Sat Jan 12 00:10:54 2019 |
| tree | 8eb13de56b658f36a7f2b9826c2a1f829c323720 | |
| parent | 372b03421362c7e14298e471451fd76223d0780d [diff] |
Add logging to debug nullptr in TabWebContentsDelegateAndroid.addNewContents Adds logging which verifies that the |delegate_| used by WebContentsImpl for WebContentsCreated is the same used for AddNewContents. A failure will result in a crash on Android. Helps debug by providing the following info: - If delegate is null at WebContentsCreated and non-null at AddNewContents, there is a race between WebContentsCreated and delegate assignment. - If delegate is non-null in both cases, but different, it means we're updating the delegate between the two, which is also not safe. - If no log messages are fired and we still crash, it means AddNewContents was called twice. Bug: 758186 Change-Id: I103cd77c148af25adb1c7002354bb3b853c913b5 Reviewed-on: https://chromium-review.googlesource.com/c/1407269 Commit-Queue: Eric Karl <[email protected]> Reviewed-by: Bo <[email protected]> Cr-Commit-Position: refs/heads/master@{#622232}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .