Rework how isolates are generated in MB.
This patch changes how MB will generate the .isolate files
for a GN build:
First, we rename 'ninja_to_gn.pyl' to 'gn_isolate_map.pyl',
and change it from a straight compile_target -> gn_label map to
a map of compile_target -> { "label": gn_label, "type": string,
"args": optional list<string> }.
Valid values for "type" are
"windowed_test_launcher"
: the test is a gtest-based test that uses the
'brave-new-test-launcher' from //base/test:test_support and
needs to run under Xvfb if run on an X11-based platform
(i.e., if use_x11=true in GN).
"console_test_launcher"
: the test is a gtest-based test that uses the
'brave-new-test-launcher' from //base/test:test_support but does
not need Xvfb.
"raw"
: the test is just an executable and may take an optional list
of command-line arguments (specified in the 'args' key),
but does not need any extra files or other special processing.
"unknown"
: (the default), which indicates that we don't know what the command
line needs to be (this is a fatal error).
Second, we read the new file in, and build a lookup map of test
types to command lines. We will probably need to keep iterating
on the list of test types and command lines, and perhaps provide
some escape hatches so that we can handle the full variety of tests.
[email protected]
BUG=503942, 504079
Review URL: https://codereview.chromium.org/1239343003
Cr-Commit-Position: refs/heads/master@{#339804}
4 files changed
