Fix presubmit check for uses of Bind, Callback, and Closure.
The excluded paths argument takes an iterable of strings and
since a string was being passed in it iterated over each character,
including a single '^', which matches all paths.
Bug: 714018
Change-Id: I3798d205bd94a356575c514e2161b935c3f843d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932037
Reviewed-by: danakj <[email protected]>
Reviewed-by: Andrew Grieve <[email protected]>
Commit-Queue: Erik Staab <[email protected]>
Cr-Commit-Position: refs/heads/master@{#718731}
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 88609352..f9ba7c64 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -926,7 +926,7 @@
'of base::Bind. (crbug.com/714018)',
),
False,
- _NOT_CONVERTED_TO_MODERN_BIND_AND_CALLBACK,
+ (_NOT_CONVERTED_TO_MODERN_BIND_AND_CALLBACK,),
),
(
r'/\bbase::Callback[<:]',
@@ -935,7 +935,7 @@
'of base::Callback. (crbug.com/714018)',
),
False,
- _NOT_CONVERTED_TO_MODERN_BIND_AND_CALLBACK,
+ (_NOT_CONVERTED_TO_MODERN_BIND_AND_CALLBACK,),
),
(
r'/\bbase::Closure\b',
@@ -944,7 +944,7 @@
'of base::Closure. (crbug.com/714018)',
),
False,
- _NOT_CONVERTED_TO_MODERN_BIND_AND_CALLBACK,
+ (_NOT_CONVERTED_TO_MODERN_BIND_AND_CALLBACK,),
),
(
r'/\bRunMessageLoop\b',
