Move idle socket timeout values to client_socket_pool_manager.cc
Pull idle socket timeout value from client_socket_pool.cc
to an upper layer client_socket_pool_manager.cc.
This CL defines the value as a static const in
client_socket_pool_manager.cc.
The next two CLs will
(i) Move the value to a higher layer of HttpNetworkSession::Params,
and from there it will be passed on to client_socket_pool_manager.cc.
(ii) Add the timeout value to mojom/network_context.mojom.
From there it will be passed on to HttpNetworkSession::Params.
Change-Id: I0d8ca7d6b9fbc77cd74e61a0ae060e39b5b0fef6
Bug: 928560
Reviewed-on: https://chromium-review.googlesource.com/c/1462150
Commit-Queue: Tarun Bansal <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#633645}diff --git a/net/socket/client_socket_pool_base_unittest.cc b/net/socket/client_socket_pool_base_unittest.cc
index 157503a..164b7f8 100644
--- a/net/socket/client_socket_pool_base_unittest.cc
+++ b/net/socket/client_socket_pool_base_unittest.cc
@@ -63,6 +63,8 @@
const int kDefaultMaxSockets = 4;
const int kDefaultMaxSocketsPerGroup = 2;
+constexpr base::TimeDelta kUnusedIdleSocketTimeout =
+ base::TimeDelta::FromSeconds(10);
// Make sure |handle| sets load times correctly when it has been assigned a
// reused socket.
@@ -739,11 +741,9 @@
}
void CreatePool(int max_sockets, int max_sockets_per_group) {
- CreatePoolWithIdleTimeouts(
- max_sockets,
- max_sockets_per_group,
- ClientSocketPool::unused_idle_socket_timeout(),
- ClientSocketPool::used_idle_socket_timeout());
+ CreatePoolWithIdleTimeouts(max_sockets, max_sockets_per_group,
+ kUnusedIdleSocketTimeout,
+ ClientSocketPool::used_idle_socket_timeout());
}
void CreatePoolWithIdleTimeouts(
