Refactored Histogram::FactoryGet() to be style-compliant
Currently, two (2) overloaded versions of Histogram::FactoryGet() exist. Google's C++ style guide discourages such implementations. I refactored the methods into Histogram::FactoryGet() (no name change), which takes 'Sample' types as arguments, and Histogram::FactoryTimeGet(), which takes base::TimeDelta types as arguments.
r = jar
Review URL: http://codereview.chromium.org/2423004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48766 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/base/histogram.cc b/base/histogram.cc
index dd02c31..1b1720ee 100644
--- a/base/histogram.cc
+++ b/base/histogram.cc
@@ -48,7 +48,7 @@
return histogram;
}
-scoped_refptr<Histogram> Histogram::FactoryGet(const std::string& name,
+scoped_refptr<Histogram> Histogram::FactoryTimeGet(const std::string& name,
base::TimeDelta minimum, base::TimeDelta maximum, size_t bucket_count,
Flags flags) {
return FactoryGet(name, minimum.InMilliseconds(), maximum.InMilliseconds(),
@@ -440,7 +440,7 @@
scoped_refptr<Histogram> render_histogram(NULL);
- if (histogram_type == HISTOGRAM) {
+ if (histogram_type == HISTOGRAM) {
render_histogram = Histogram::FactoryGet(
histogram_name, declared_min, declared_max, bucket_count, flags);
} else if (histogram_type == LINEAR_HISTOGRAM) {
