| commit | a850a303ffd0925ac1378a00467dc50cfb482451 | [log] [tgz] |
|---|---|---|
| author | Chris Watkins <[email protected]> | Thu Nov 30 03:53:49 2017 |
| committer | Commit Bot <[email protected]> | Thu Nov 30 03:53:49 2017 |
| tree | 73b68300212c5609c9730f16bd4145f88fb08940 | |
| parent | f42f03281ac1c9c0749d89aae85c15fac7c9ead4 [diff] [blame] |
Run clang-tidy modernize-use-equals-{delete,default} on //crypto
See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8
This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md
In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
git diff --name-only | \
xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'
BUG=778959,778957
Change-Id: Ie37f2c19a84ecdce173b34b27a0a63c187b3f54a
Reviewed-on: https://chromium-review.googlesource.com/789740
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: Chris Watkins <[email protected]>
Cr-Commit-Position: refs/heads/master@{#520426}diff --git a/crypto/aead.cc b/crypto/aead.cc index 99d1603..83187ba7 100644 --- a/crypto/aead.cc +++ b/crypto/aead.cc
@@ -24,8 +24,7 @@ } } -Aead::~Aead() { -} +Aead::~Aead() = default; void Aead::Init(const std::string* key) { DCHECK(!key_);