GTTF: Enable glibcxx debug mode for Debug builds by default.
This will help us catch problems earlier.
This CL actually fixes several problems detected by this mode.
BUG=65151, 267870, 267891
TEST=none
[email protected], [email protected], [email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/22243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239811 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/build/common.gypi b/build/common.gypi
index 211074c..445cd644 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1099,8 +1099,6 @@
# Profile without optimizing out stack frames when profiling==1.
'profiling_full_stack_frames%': '0',
- # Enable strict glibc debug mode.
- 'glibcxx_debug%': 0,
# And if we want to dump symbols for Breakpad-enabled builds.
'linux_dump_symbols%': 0,
# And if we want to strip the binary after dumping symbols.
@@ -2158,10 +2156,6 @@
['profiling==1', {
'defines': ['ENABLE_PROFILING=1'],
}],
- ['OS=="linux" and glibcxx_debug==1', {
- 'defines': ['_GLIBCXX_DEBUG=1',],
- 'cflags_cc+': ['-g'],
- }],
['remoting==1', {
'defines': ['ENABLE_REMOTING=1'],
}],
@@ -2740,6 +2734,12 @@
}],
],
}],
+ ['OS=="linux" and target_arch!="ia32"', {
+ # Enable libstdc++ debugging facilities to help catch problems
+ # early, see http://crbug.com/65151 .
+ # TODO(phajdan.jr): Should we enable this for all of POSIX?
+ 'defines': ['_GLIBCXX_DEBUG=1',],
+ }],
# Disabled on iOS because it was causing a crash on startup.
# TODO(michelea): investigate, create a reduced test and possibly
# submit a radar.
