Google Git
Sign in
chromium / chromium / src.git / aa2a8b5fb112e7e0d90d0f19d43f56c60bcf4406
commitaa2a8b5fb112e7e0d90d0f19d43f56c60bcf4406[log] [tgz]
authorCammie Smith Barnes <[email protected]>Thu Dec 17 19:33:19 2020
committerChromium LUCI CQ <[email protected]>Thu Dec 17 19:33:19 2020
tree7d01dabeead1ec2e57afef48972287ca341414ed
parented4d77df67210e77fcffd23e1694dcefa8091824 [diff]
Net: Plumb CNAME aliases to sockets with aim of exposing to ad-tagging.

The overall project aims to expose CNAME aliases to the
SubresourceFilter to aid in ad tagging and blocking.

A previous CL stored CNAME aliases in net::AddressList during
DNS resolution. This CL's parent added an accessor to
net::ResolveHostRequest/net::HostResolverManager::RequestImpl.

This change continues the plumbing by adding a base::Optional parameter
to net::ConnectJob::SetSocket.

net::Socket, on the other hand, gains both a getter and a setter for
the aliases, which need to be stored in the sockets in case of socket
reuse. But only three derived classes get a nontrivial implementation
with an actual field to store the aliases: net::TCPClientSocket,
net::SSLClientSocketImpl, and net::WebSocketStreamSocket.

Relevant tests:
net:net_unittests
out/Default/net_unittests --gtest_filter=*Dns*Alias*

Bug: 1151047
Change-Id: Ib1d8f6d8358aa445fad9051218336ec9953ff9b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563439
Commit-Queue: Cammie Smith Barnes <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Cr-Commit-Position: refs/heads/master@{#838179}
19 files changed
tree: 7d01dabeead1ec2e57afef48972287ca341414ed
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.