| commit | aa441f50eecca13f2d3490a89705cb00cc0d5920 | [log] [tgz] |
|---|---|---|
| author | thomasanderson <[email protected]> | Tue Apr 04 22:35:39 2017 |
| committer | Commit bot <[email protected]> | Tue Apr 04 22:35:39 2017 |
| tree | d9028a4f5f6cf065f68115b71bb1f9c8523abd21 | |
| parent | f01aa36d574f86cbadec43d22773c1f25dc20a90 [diff] |
Revert of Instrumented libraries: Remove dependence on GYP_DEFINES (patchset #2 id:60001 of https://codereview.chromium.org/2775913002/ ) Reason for revert: Reverting now that all of the third_party changes have been reverted Original issue's description: > Instrumented libraries: Remove dependence on GYP_DEFINES > > This CL ports download_binaries.py and unpack_binaries.py from using > GYP_DEFINES to gn args. Previously, there was a gotcha step where you > had to run 'gclient sync' with the right GYP_DEFINES to actually download > the prebuilt instrumented libraries. This CL removes that step. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng > [email protected] > BUG=705072 > > Review-Url: https://codereview.chromium.org/2775913002 > Cr-Commit-Position: refs/heads/master@{#459630} > Committed: https://chromium.googlesource.com/chromium/src/+/5adb8c047852670be6c9d42114f3a17d44b6c56e [email protected],[email protected],[email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=705072 Review-Url: https://codereview.chromium.org/2792343003 Cr-Commit-Position: refs/heads/master@{#461871}