| commit | ad6c523b9de20fbed7bbcf980736c212526a2ae0 | [log] [tgz] |
|---|---|---|
| author | François Beaufort <[email protected]> | Mon Feb 26 11:00:44 2018 |
| committer | Commit Bot <[email protected]> | Mon Feb 26 11:00:44 2018 |
| tree | 1688fceaae157d164fad2edd5b8a1cb9d5ad5bd3 | |
| parent | d49a775061c3d506d9cb869d8c087e0779a4d912 [diff] [blame] |
Prevent auto-PiP if disablePictureInPicture video attribute is set. This CLs makes sure fullscreen videos don't enter automatically Picture-in-Picture if the disablePictureInPicture attribute is set on the video element. Test page: https://beaufortfrancois.github.io/sandbox/media/disable-pip.html Bug: 806249 Change-Id: I3621ef58c8f1778d54865eca6cc30a736994d493 Reviewed-on: https://chromium-review.googlesource.com/918421 Commit-Queue: François Beaufort <[email protected]> Reviewed-by: Mounir Lamouri <[email protected]> Reviewed-by: Dale Curtis <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Cr-Commit-Position: refs/heads/master@{#539106}
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h index abd051f..84a01a83 100644 --- a/content/browser/web_contents/web_contents_impl.h +++ b/content/browser/web_contents/web_contents_impl.h
@@ -905,6 +905,11 @@ // |IsFullscreen| must return |true| when this method is called. bool HasActiveEffectivelyFullscreenVideo() const; + // Whether the WebContents effectively fullscreen active player allows + // Picture-in-Picture. + // |IsFullscreen| must return |true| when this method is called. + bool IsPictureInPictureAllowedForFullscreenVideo() const; + // When inner or outer WebContents are present, become the focused // WebContentsImpl. This will activate this content's main frame RenderWidget // and indirectly all its subframe widgets. GetFocusedRenderWidgetHost will