Google Git
Sign in
chromium / chromium / src.git / b0207d7006fa7f61182b7b73d1b4ca212e4cf356
commitb0207d7006fa7f61182b7b73d1b4ca212e4cf356[log] [tgz]
authorKenichi Ishibashi <[email protected]>Wed Feb 09 22:06:36 2022
committerChromium LUCI CQ <[email protected]>Wed Feb 09 22:06:36 2022
tree7009a437325a298a05709aa49ec7c662e9077c1d
parent8528c9d9fe639e5c8a8219bd539dc6c676137a8b [diff]
Treat END_STREAM as EOF in SpdyProxyClientSocket

Per the spec[1], when the CONNECT method is used, a DATA frame with
END_STREAM should be treated as being equivalent to the TCP FIN bit.
However, before this CL SpdyProxyClientSocket didn't treat END_STREAM
as EOF. This resulted in an infinite resource loading when the response
didn't contain the Content-Length header.

Send a DATA frame with END_STREAM after receiving END_STREAM from the
proxy to close the underlying stream, as the spec requires.

[1] https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-http2bis-07#section-8.5

Bug: 1078554
Change-Id: I1f4b61379fea24078e3760e2b9d648cef323f6f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3449470
Reviewed-by: Bence Béky <[email protected]>
Commit-Queue: Kenichi Ishibashi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#969134}
3 files changed
tree: 7009a437325a298a05709aa49ec7c662e9077c1d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.