Google Git
Sign in
chromium / chromium / src.git / b042bb4ecc9511059f5d73c375ecdf00e47e264a
commitb042bb4ecc9511059f5d73c375ecdf00e47e264a[log] [tgz]
authorCarlos Frias <[email protected]>Wed Oct 14 17:23:11 2020
committerCommit Bot <[email protected]>Wed Oct 14 17:23:11 2020
tree14fcd4716971a85fd081898923ea67b82db1e66b
parent47ecb6a8cf01096b236106f70ebcd97ebb33e2be [diff]
DPWA: Add Run on OS Login UX as context menu option in chrome://apps

This CL adds a new context menu option to enable/disable Run on OS Login
for a web app listed in chrome://apps list. The context menu option will
be shown only when the web app is locally installed and the feature flag
for Run on OS Login is enabled.

Handler for UX activation is to call OsIntegrationManager class and
install or uninstall the Run on OS Login hook as indicated by the user.

Testing was performed by manual testing in chrome://apps by right click
on app icon, and verifying the new UI option is only shown for installed
web apps, and also verifying the activation handler calls the
OsIntegrationManger's APIs.

The manual testing guidance document describing these tests can be found
here:
https://docs.google.com/document/d/1XlvL17xAGivmQNiHaUCYBcGtnkPpZ0GijjjWpCma5H4/edit

Bug: 1110407
Change-Id: Ifef1cb57068b0836248f3a780ccff6e051abaf03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401902
Commit-Queue: Carlos Frias <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#817073}
8 files changed
tree: 14fcd4716971a85fd081898923ea67b82db1e66b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.