| commit | b40fd36089a72b629c6acd333f7be8ec5765501d | [log] [tgz] |
|---|---|---|
| author | Samuel Huang <[email protected]> | Wed Jul 07 18:06:52 2021 |
| committer | Chromium LUCI CQ <[email protected]> | Wed Jul 07 18:06:52 2021 |
| tree | 2260ee47cafbbc0fc7e0957d5ae3d2d49d9af0f1 | |
| parent | e141ef20f9ec594655e1133eebe7ca260b595ca0 [diff] |
[Lacros] Add and use LacrosDBusThreadManager.
Lacros will need chromeos::PermissionBrokerClient to support
{Gamepad, chrome.hid, WebHID, chrome.serial, Web Serial, chrome.usb,
WebUSB} APIs. This is a D-Bus client whose initialization in Ash uses
chromeos::DBusThreadManager.
Unfortunately, having Lacros use DBusThreadManager adds //chromeos/dbus
dependency. This would pull in a great deal of Ash-only deps and code,
and these require rather intrusive changes to exclude for Lacros.
The solution taken is to duplicate the minimal amount of code needed
to have Lacros support chromeos::PermissionBrokerClient, noting that
it's unlikely for Lacros to add more D-Bus dependencies in the near
future. This CL Adds
chromeos::LacrosDBusThreadManager
chromeos::LacrosInitializeDBus()
chromeos::LacrosShutdownDBus()
as Lacros counterparts to
chromeos::DBusThreadManager
ash::InitializeDBus()
ash::ShutdownDBus()
and makes matching initialization / shutdown calls for Lacros chrome and
tests to match Ash calls.
Bug: 1195247, 1195248, 1217124, 1223456
Change-Id: I0da8680e0e93a9a92cdb28bbfca7712874a1afca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2983066
Reviewed-by: Hidehiko Abe <[email protected]>
Reviewed-by: Steven Bennetts <[email protected]>
Reviewed-by: danakj <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Erik Chen <[email protected]>
Commit-Queue: Samuel Huang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#899201}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.