Swap deprecated BrowserList:: iterators for BrowserIterator in code not compiled in WinAura builds.
Hardcoding HOST_DESKTOP_TYPE where necessary.
BUG=129187
Review URL: https://chromiumcodereview.appspot.com/12213075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181887 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
index 01642fd..037c125d 100644
--- a/chrome/browser/app_controller_mac.mm
+++ b/chrome/browser/app_controller_mac.mm
@@ -41,6 +41,7 @@
#include "chrome/browser/ui/browser_command_controller.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_mac.h"
#include "chrome/browser/ui/browser_window.h"
@@ -984,8 +985,7 @@
// visible windows are panels or notifications, we still need to open a new
// window.
if (flag) {
- for (BrowserList::const_iterator iter = BrowserList::begin();
- iter != BrowserList::end(); ++iter) {
+ for (chrome::BrowserIterator iter; !iter.done(); iter.Next()) {
Browser* browser = *iter;
if (browser->is_type_tabbed() || browser->is_type_popup())
return YES;
diff --git a/chrome/browser/app_controller_mac_browsertest.mm b/chrome/browser/app_controller_mac_browsertest.mm
index ff342780..aec0f00 100644
--- a/chrome/browser/app_controller_mac_browsertest.mm
+++ b/chrome/browser/app_controller_mac_browsertest.mm
@@ -10,6 +10,8 @@
#import "chrome/browser/app_controller_mac.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_list_impl.h"
+#include "chrome/browser/ui/host_desktop.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#import "chrome/common/chrome_switches.h"
#include "chrome/test/base/in_process_browser_test.h"
@@ -20,12 +22,18 @@
class AppControllerPlatformAppBrowserTest : public InProcessBrowserTest {
protected:
- AppControllerPlatformAppBrowserTest() {}
+ AppControllerPlatformAppBrowserTest()
+ : native_browser_list(chrome::BrowserListImpl::GetInstance(
+ chrome::HOST_DESKTOP_TYPE_NATIVE)) {
+ }
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
command_line->AppendSwitchASCII(switches::kAppId,
"1234");
}
+
+ // Mac only has the native desktop.
+ const chrome::BrowserListImpl* native_browser_list;
};
// Test that if only a platform app window is open and no browser windows are
@@ -34,17 +42,20 @@
PlatformAppReopenWithWindows) {
scoped_nsobject<AppController> ac([[AppController alloc] init]);
NSUInteger old_window_count = [[NSApp windows] count];
- EXPECT_EQ(1u, BrowserList::size());
+ EXPECT_EQ(1u, native_browser_list->size());
BOOL result = [ac applicationShouldHandleReopen:NSApp hasVisibleWindows:YES];
EXPECT_TRUE(result);
EXPECT_EQ(old_window_count, [[NSApp windows] count]);
- EXPECT_EQ(1u, BrowserList::size());
+ EXPECT_EQ(1u, native_browser_list->size());
}
class AppControllerWebAppBrowserTest : public InProcessBrowserTest {
protected:
- AppControllerWebAppBrowserTest() {}
+ AppControllerWebAppBrowserTest()
+ : native_browser_list(chrome::BrowserListImpl::GetInstance(
+ chrome::HOST_DESKTOP_TYPE_NATIVE)) {
+ }
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
command_line->AppendSwitchASCII(switches::kApp, GetAppURL());
@@ -53,19 +64,22 @@
std::string GetAppURL() const {
return "http://example.com/";
}
+
+ // Mac only has the native desktop.
+ const chrome::BrowserListImpl* native_browser_list;
};
// Test that in web app mode a reopen event opens the app URL.
IN_PROC_BROWSER_TEST_F(AppControllerWebAppBrowserTest,
WebAppReopenWithNoWindows) {
scoped_nsobject<AppController> ac([[AppController alloc] init]);
- EXPECT_EQ(1u, BrowserList::size());
+ EXPECT_EQ(1u, native_browser_list->size());
BOOL result = [ac applicationShouldHandleReopen:NSApp hasVisibleWindows:NO];
EXPECT_FALSE(result);
- EXPECT_EQ(2u, BrowserList::size());
+ EXPECT_EQ(2u, native_browser_list->size());
- Browser* browser = *(BrowserList::begin());
+ Browser* browser = native_browser_list->get(0);
GURL current_url =
browser->tab_strip_model()->GetActiveWebContents()->GetURL();
EXPECT_EQ(GetAppURL(), current_url.spec());
diff --git a/chrome/browser/chromeos/boot_times_loader.cc b/chrome/browser/chromeos/boot_times_loader.cc
index 8e522d48..e39005ed 100644
--- a/chrome/browser/chromeos/boot_times_loader.cc
+++ b/chrome/browser/chromeos/boot_times_loader.cc
@@ -25,7 +25,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chromeos/login/authentication_notification_details.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_switches.h"
@@ -56,9 +56,7 @@
const std::string GetTabUrl(RenderWidgetHost* rwh) {
RenderWidgetHostView* rwhv = rwh->GetView();
- for (BrowserList::const_iterator it = BrowserList::begin();
- it != BrowserList::end();
- ++it) {
+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {
Browser* browser = *it;
for (int i = 0, tab_count = browser->tab_strip_model()->count();
i < tab_count;
diff --git a/chrome/browser/chromeos/extensions/file_manager_util.cc b/chrome/browser/chromeos/extensions/file_manager_util.cc
index a68e93ec..bf700e8 100644
--- a/chrome/browser/chromeos/extensions/file_manager_util.cc
+++ b/chrome/browser/chromeos/extensions/file_manager_util.cc
@@ -32,7 +32,7 @@
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/extensions/application_launch.h"
@@ -310,9 +310,8 @@
const GURL origin(chrome::kChromeUIFileManagerURL);
const std::string ref = std::string("/") + path.value();
- for (BrowserList::const_iterator browser_iterator = BrowserList::begin();
- browser_iterator != BrowserList::end(); ++browser_iterator) {
- Browser* browser = *browser_iterator;
+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {
+ Browser* browser = *it;
TabStripModel* tab_strip = browser->tab_strip_model();
for (int idx = 0; idx < tab_strip->count(); idx++) {
content::WebContents* web_contents = tab_strip->GetWebContentsAt(idx);
@@ -434,9 +433,8 @@
}
Browser* GetBrowserForUrl(GURL target_url) {
- for (BrowserList::const_iterator browser_iterator = BrowserList::begin();
- browser_iterator != BrowserList::end(); ++browser_iterator) {
- Browser* browser = *browser_iterator;
+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {
+ Browser* browser = *it;
TabStripModel* tab_strip = browser->tab_strip_model();
for (int idx = 0; idx < tab_strip->count(); idx++) {
content::WebContents* web_contents = tab_strip->GetWebContentsAt(idx);
diff --git a/chrome/browser/chromeos/media/media_player.cc b/chrome/browser/chromeos/media/media_player.cc
index e162c07..d22a90e 100644
--- a/chrome/browser/chromeos/media/media_player.cc
+++ b/chrome/browser/chromeos/media/media_player.cc
@@ -14,7 +14,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ -153,9 +153,8 @@
}
Browser* MediaPlayer::GetBrowser() {
- for (BrowserList::const_iterator browser_iterator = BrowserList::begin();
- browser_iterator != BrowserList::end(); ++browser_iterator) {
- Browser* browser = *browser_iterator;
+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {
+ Browser* browser = *it;
TabStripModel* tab_strip = browser->tab_strip_model();
for (int idx = 0; idx < tab_strip->count(); idx++) {
const GURL& url = tab_strip->GetWebContentsAt(idx)->GetURL();
diff --git a/chrome/browser/chromeos/media/media_player_browsertest.cc b/chrome/browser/chromeos/media/media_player_browsertest.cc
index b5b15ca..4931113a 100644
--- a/chrome/browser/chromeos/media/media_player_browsertest.cc
+++ b/chrome/browser/chromeos/media/media_player_browsertest.cc
@@ -7,7 +7,7 @@
#include "base/utf_string_conversions.h"
#include "chrome/browser/chromeos/media/media_player.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
@@ -24,9 +24,8 @@
bool IsBrowserVisible(Browser* browser) {
if (browser == NULL)
return false;
- for (BrowserList::const_iterator it = BrowserList::begin();
- it != BrowserList::end(); ++it) {
- if ((*it)->is_type_popup() && (*it)->is_app() && (*it) == browser)
+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {
+ if (it->is_type_popup() && it->is_app() && (*it) == browser)
return true;
}
return false;
diff --git a/chrome/browser/chromeos/memory/oom_priority_manager.cc b/chrome/browser/chromeos/memory/oom_priority_manager.cc
index 6cae3ea..cb15d97 100644
--- a/chrome/browser/chromeos/memory/oom_priority_manager.cc
+++ b/chrome/browser/chromeos/memory/oom_priority_manager.cc
@@ -27,6 +27,7 @@
#include "chrome/browser/chromeos/memory/low_memory_observer.h"
#include "chrome/browser/memory_details.h"
#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ -265,9 +266,8 @@
}
bool OomPriorityManager::DiscardTabById(int64 target_web_contents_id) {
- for (BrowserList::const_iterator browser_iterator = BrowserList::begin();
- browser_iterator != BrowserList::end(); ++browser_iterator) {
- Browser* browser = *browser_iterator;
+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {
+ Browser* browser = *it;
TabStripModel* model = browser->tab_strip_model();
for (int idx = 0; idx < model->count(); idx++) {
// Can't discard tabs that are already discarded or active.
@@ -362,11 +362,8 @@
int OomPriorityManager::GetTabCount() const {
int tab_count = 0;
- for (BrowserList::const_iterator browser_it = BrowserList::begin();
- browser_it != BrowserList::end(); ++browser_it) {
- Browser* browser = *browser_it;
- tab_count += browser->tab_strip_model()->count();
- }
+ for (chrome::BrowserIterator it; !it.done(); it.Next())
+ tab_count += it->tab_strip_model()->count();
return tab_count;
}
diff --git a/chrome/browser/download/download_status_updater_win.cc b/chrome/browser/download/download_status_updater_win.cc
index adf9458..fc96f4a 100644
--- a/chrome/browser/download/download_status_updater_win.cc
+++ b/chrome/browser/download/download_status_updater_win.cc
@@ -16,7 +16,7 @@
#include "base/win/windows_version.h"
#include "chrome/browser/platform_util.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_window.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/browser_thread.h"
@@ -56,9 +56,8 @@
}
// Iterate through all the browser windows, and draw the progress bar.
- for (BrowserList::const_iterator browser_iterator = BrowserList::begin();
- browser_iterator != BrowserList::end(); browser_iterator++) {
- Browser* browser = *browser_iterator;
+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {
+ Browser* browser = *it;
BrowserWindow* window = browser->window();
if (!window)
continue;
diff --git a/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm b/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm
index a9740bbb..a8c7bdd 100644
--- a/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm
+++ b/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm
@@ -11,6 +11,7 @@
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_list.h"
#import "chrome/browser/ui/cocoa/applescript/bookmark_folder_applescript.h"
#import "chrome/browser/ui/cocoa/applescript/constants_applescript.h"
@@ -24,8 +25,8 @@
arrayWithCapacity:BrowserList::size()];
// Iterate through all browsers and check if it closing,
// if not add it to list.
- for (BrowserList::const_iterator browserIterator = BrowserList::begin();
- browserIterator != BrowserList::end(); ++browserIterator) {
+ for (chrome::BrowserIterator browserIterator; !browserIterator.done();
+ browserIterator.Next()) {
if ((*browserIterator)->IsAttemptingToCloseBrowser())
continue;
diff --git a/chrome/browser/ui/gtk/gtk_theme_service.cc b/chrome/browser/ui/gtk/gtk_theme_service.cc
index 1c18aeb..2ffcee5 100644
--- a/chrome/browser/ui/gtk/gtk_theme_service.cc
+++ b/chrome/browser/ui/gtk/gtk_theme_service.cc
@@ -17,7 +17,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/themes/theme_service_factory.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/gtk/chrome_gtk_frame.h"
#include "chrome/browser/ui/gtk/gtk_chrome_button.h"
@@ -653,9 +653,8 @@
gtk_util::SetLabelColor(it->first, color);
}
- for (BrowserList::const_iterator browser_iterator = BrowserList::begin();
- browser_iterator != BrowserList::end(); browser_iterator++) {
- Browser* browser = (*browser_iterator);
+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {
+ Browser* browser = *it;
if (!browser->window())
continue;
GtkWindow* window = browser->window()->GetNativeWindow();
diff --git a/chrome/browser/ui/gtk/gtk_util.cc b/chrome/browser/ui/gtk/gtk_util.cc
index eedb5be..b2ad168 100644
--- a/chrome/browser/ui/gtk/gtk_util.cc
+++ b/chrome/browser/ui/gtk/gtk_util.cc
@@ -24,10 +24,12 @@
#include "chrome/browser/profiles/profile_info_cache.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_iterator.h"
+#include "chrome/browser/ui/browser_list_impl.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/gtk/browser_window_gtk.h"
#include "chrome/browser/ui/gtk/gtk_theme_service.h"
+#include "chrome/browser/ui/host_desktop.h"
#include "googleurl/src/gurl.h"
#include "grit/chrome_unscaled_resources.h"
#include "grit/theme_resources.h"
@@ -412,8 +414,7 @@
// we need to add current non-browser modal dialogs to the list. If
// we have 2.14+ we can do things the correct way.
GtkWindowGroup* window_group = gtk_window_group_new();
- for (BrowserList::const_iterator it = BrowserList::begin();
- it != BrowserList::end(); ++it) {
+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {
// List all windows in this current group
GtkWindowGroup* old_group =
gtk_window_get_group((*it)->window()->GetNativeWindow());
@@ -428,12 +429,15 @@
}
void AppModalDismissedUngroupWindows() {
- if (BrowserList::begin() != BrowserList::end()) {
+ // GTK only has the native desktop.
+ const chrome::BrowserListImpl* native_browser_list =
+ chrome::BrowserListImpl::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE);
+ if (!native_browser_list->empty()) {
std::vector<GtkWindow*> transient_windows;
// All windows should be part of one big modal group right now.
GtkWindowGroup* window_group = gtk_window_get_group(
- (*BrowserList::begin())->window()->GetNativeWindow());
+ native_browser_list->get(0)->window()->GetNativeWindow());
GList* windows = gtk_window_group_list_windows(window_group);
for (GList* item = windows; item; item = item->next) {
diff --git a/chrome/browser/ui/panels/panel_browsertest.cc b/chrome/browser/ui/panels/panel_browsertest.cc
index 47fb654f..57f3b58 100644
--- a/chrome/browser/ui/panels/panel_browsertest.cc
+++ b/chrome/browser/ui/panels/panel_browsertest.cc
@@ -16,7 +16,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/panels/base_panel_browser_test.h"
#include "chrome/browser/ui/panels/docked_panel_collection.h"
@@ -1661,8 +1661,7 @@
// Check that the new browser window that opened is dev tools window.
++num_browsers;
EXPECT_EQ(num_browsers, chrome::GetBrowserCount(browser()->profile()));
- for (BrowserList::const_iterator iter = BrowserList::begin();
- iter != BrowserList::end(); ++iter) {
+ for (chrome::BrowserIterator iter; !iter.done(); iter.Next()) {
if (*iter == browser())
continue;
ASSERT_TRUE((*iter)->is_devtools());
@@ -1692,8 +1691,7 @@
// Check that the new browser window that opened is dev tools window.
++num_browsers;
EXPECT_EQ(num_browsers, chrome::GetBrowserCount(browser()->profile()));
- for (BrowserList::const_iterator iter = BrowserList::begin();
- iter != BrowserList::end(); ++iter) {
+ for (chrome::BrowserIterator iter; !iter.done(); iter.Next()) {
if (*iter == browser())
continue;
ASSERT_TRUE((*iter)->is_devtools());
