| commit | b7559455b0d4ad603198d6c11c4ec7a60104357a | [log] [tgz] |
|---|---|---|
| author | Oleg Davydov <[email protected]> | Fri Feb 07 15:01:25 2020 |
| committer | Commit Bot <[email protected]> | Fri Feb 07 15:01:25 2020 |
| tree | 4dd05115909daed5d36ff42754240c3e193aa004 | |
| parent | caf530528452e632bc5e14217402f6d8c50e6846 [diff] |
[Extensions] Make g_test_content_verify_job_observer thread-safe ContentVerifyJob has ability to inject test observer, but before this CL the observer is accessed from different threads, leading to flaky crashes in tests. See https://crrev.com/c/2032998. Now this observer (ContentVerifyJob::TestObserver and pointer to it from g_test_content_verify_gob_observer in content_verify_job.cc) supports thread-safe refcounted pointing, therefore is not destroyed too early. Also it's wrappend into lazy initialized since we need access to it be no-op outside of the tests. Bug: 796395, 958794 Change-Id: I7479216f23083d4fd41dae08cb2e7acb62da0abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033159 Reviewed-by: Sergey Poromov <[email protected]> Reviewed-by: Istiaque Ahmed <[email protected]> Commit-Queue: Oleg Davydov <[email protected]> Cr-Commit-Position: refs/heads/master@{#739387}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .