| commit | b88837e9c0cdf9ee604258d19d053b93ba76d748 | [log] [tgz] |
|---|---|---|
| author | Matt Menke <[email protected]> | Wed Mar 20 11:50:40 2019 |
| committer | Commit Bot <[email protected]> | Wed Mar 20 11:50:40 2019 |
| tree | 9703029484473f2dbfe5db0309c9fb87924c8094 | |
| parent | a46ba950efb6e26508e4707c5786cf9c2954452c [diff] |
Remove HttpNetworkSession argument from CreateSocketParamsAndGetGroupId. Instead, this CL adds pointers to several global objects are to CommonConnectJobParams, and moves the logic for testing_fixed_http_port over to the calling function - it affects the endpoint used, which affects part of the group_id, and hence is fine to keep around. In order to avoid pooling sockets created with different SocketParams, we're working on making it so there's a 1-to-1 mapping between GroupIds and SocketParams. To that end, we're removing objects used to create SocketParams. Bug: 921369 Change-Id: Ib5b234ab8f4cc0c45c97d5a4c4e46e6e885536b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531083 Commit-Queue: Matt Menke <[email protected]> Reviewed-by: Ryan Hamilton <[email protected]> Cr-Commit-Position: refs/heads/master@{#642470}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .